Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to disable containers tooling (#1367) #1375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blackheaven
Copy link

No description provided.

@domenkozar
Copy link
Member

Nice! Any chance to separate styling changes from the behavior change?

@blackheaven
Copy link
Author

Actually it's enforced by the pre-commit hook.

I can try to make a first commit with only formatting, would it be okay?

@domenkozar
Copy link
Member

That would be perfect, thank you!

@blackheaven
Copy link
Author

done :)

@sandydoo
Copy link
Member

sandydoo commented Aug 12, 2024

Actually it's enforced by the pre-commit hook.

@blackheaven, are you sure it's not your editor's tooling doing the formatting? This doesn't look like nixpkgs-fmt to me. If it really is, I'll have to investigate why our hooks are broken.

@blackheaven
Copy link
Author

@blackheaven, are you sure it's not your editor's tooling doing the formatting? This doesn't look like nixpkgs-fmt to me. If it really is, I'll have to investigate why our hooks are broken.

I think my language server formatted twice, anyway, it's fixed now.

@domenkozar
Copy link
Member

The main reason why I haven't merged this yet is because I'm not convinced what the API should look like.

Maybe we should add something like containers.<name>.contents = []; that would imply to build the container from scratch?

src/modules/containers.nix Outdated Show resolved Hide resolved
@blackheaven
Copy link
Author

@Mic92 Thank you so much!

@blackheaven
Copy link
Author

Maybe we should add something like containers.<name>.contents = []; that would imply to build the container from scratch?

Should we check that for other parameters? (i.e. perms, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants